[Naming] Skip DateTime from renaming, to keep convention of named dat…

…es (#5184)
rectorphp · Oct 18, 2023 · beeba17 · beeba17
1 parent 369f16a
commit beeba17
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 6 deletions.
diff --git a/rules-tests/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector/Fixture/keep_date.php.inc b/rules-tests/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector/Fixture/keep_date.php.inc
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Fixture;
+
+final class KeepDate
+{
+    private function getItemByRefOrNull(?\DateTime $startDate)
+    {
+    }
+}
diff --git a/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php b/rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php
@@ -4,9 +4,9 @@
 
 namespace Rector\DeadCode\Rector\If_;
 
-use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt;

diff --git a/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php b/rules/Naming/ExpectedNameResolver/MatchParamTypeExpectedNameResolver.php
@@ -6,6 +6,7 @@
 
 use PhpParser\Node\Param;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
 use Rector\Naming\Naming\PropertyNaming;
 use Rector\Naming\ValueObject\ExpectedName;
 use Rector\StaticTypeMapper\StaticTypeMapper;
@@ -29,7 +30,7 @@ public function resolve(Param $param): ?string
 
         // include nullable too
         // skip date time + date time interface, as should be kept
-        if ($staticType->isSuperTypeOf(new ObjectType('DateTimeInterface'))->yes()) {
+        if ($this->isDateTimeType($staticType)) {
             return null;
         }
 
@@ -40,4 +41,14 @@ public function resolve(Param $param): ?string
 
         return $expectedName->getName();
     }
+
+    private function isDateTimeType(Type $type): bool
+    {
+        if ($type->isSuperTypeOf(new ObjectType('DateTimeInterface'))->yes()) {
+            return true;
+        }
+
+        return $type->isSuperTypeOf(new ObjectType('DateTime'))
+            ->yes();
+    }
 }
diff --git a/src/PhpParser/Node/BetterNodeFinder.php b/src/PhpParser/Node/BetterNodeFinder.php
@@ -192,7 +192,7 @@ static function (Node $subNode) use ($types, &$isFoundNode): ?int {
      * @return T[]
      */
     public function findInstancesOfInFunctionLikeScoped(
-        ClassMethod | Function_ | Closure  $functionLike,
+        ClassMethod | Function_ | Closure $functionLike,
         string|array $types
     ): array {
         if (is_string($types)) {

diff --git a/tests/Issues/ScopeNotAvailable/config/match_to_switch_reflection.php b/tests/Issues/ScopeNotAvailable/config/match_to_switch_reflection.php
@@ -3,12 +3,12 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\DowngradePhp81\Rector\StmtsAwareInterface\DowngradeSetAccessibleReflectionPropertyRector;
 use Rector\DowngradePhp80\Rector\Expression\DowngradeMatchToSwitchRector;
+use Rector\DowngradePhp81\Rector\StmtsAwareInterface\DowngradeSetAccessibleReflectionPropertyRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules([
-       DowngradeSetAccessibleReflectionPropertyRector::class,
-       DowngradeMatchToSwitchRector::class,
+        DowngradeSetAccessibleReflectionPropertyRector::class,
+        DowngradeMatchToSwitchRector::class,
     ]);
 };