remove extra parma in value object

rectorphp · Jun 22, 2021 · c2ce610 · c2ce610
1 parent 7bba40a
commit c2ce610
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/config/set/downgrade-php80.php b/config/set/downgrade-php80.php
@@ -38,7 +38,7 @@
     $services->set(DowngradeAttributeToAnnotationRector::class)
         ->call('configure', [[
             DowngradeAttributeToAnnotationRector::ATTRIBUTE_TO_ANNOTATION => ValueObjectInliner::inline([
-                new DowngradeAttributeToAnnotation('Attribute', 'Attribute'),
+                new DowngradeAttributeToAnnotation('Attribute'),
             ]),
         ]]);
 

diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php
@@ -73,10 +73,7 @@ public function action()
                 ,
                 [
                     self::ATTRIBUTE_TO_ANNOTATION => [
-                        new DowngradeAttributeToAnnotation(
-                            'Symfony\Component\Routing\Annotation\Route',
-                            'Symfony\Component\Routing\Annotation\Route'
-                        ),
+                        new DowngradeAttributeToAnnotation('Symfony\Component\Routing\Annotation\Route'),
                     ],
                 ]
             ),

diff --git a/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php b/rules/DowngradePhp80/ValueObject/DowngradeAttributeToAnnotation.php
@@ -8,11 +8,11 @@ final class DowngradeAttributeToAnnotation
 {
     /**
      * @param class-string $attributeClass
-     * @param class-string|string $tag
+     * @param class-string|string|null $tag
      */
     public function __construct(
         private string $attributeClass,
-        private string $tag
+        private ?string $tag = null
     ) {
     }
 
@@ -23,6 +23,10 @@ public function getAttributeClass(): string
 
     public function getTag(): string
     {
+        if ($this->tag === null) {
+            return $this->attributeClass;
+        }
+
         return $this->tag;
     }
 }