[Strict] Add rules to resolve PHPStan Strict rule set (#955)

Co-authored-by: GitHub Action <action@github.com>

build/target-repository/docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 477 Rules Overview
+# 482 Rules Overview
 
 <br>
 
@@ -92,6 +92,8 @@
 
 - [Restoration](#restoration) (6)
 
+- [Strict](#strict) (5)
+
 - [Transform](#transform) (34)
 
 - [TypeDeclaration](#typedeclaration) (20)
@@ -9774,6 +9776,111 @@ Rename file to respect class name
 
 <br>
 
+## Strict
+
+### BooleanInBooleanNotRuleFixerRector
+
+Fixer for PHPStan reports by strict type rule - "PHPStan\Rules\BooleansInConditions\BooleanInBooleanNotRule"
+
+- class: [`Rector\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector`](../rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php)
+
+```diff
+ class SomeClass
+ {
+     public function run(string $name)
+     {
+-        if (! $name) {
++        if ($name !== '') {
+             return 'name';
+         }
+
+         return 'no name';
+     }
+ }
+```
+
+<br>
+
+### BooleanInIfConditionRuleFixerRector
+
+Fixer for PHPStan reports by strict type rule - "PHPStan\Rules\BooleansInConditions\BooleanInIfConditionRule"
+
+- class: [`Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector`](../rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php)
+
+```diff
+ final class NegatedString
+ {
+     public function run(string $name)
+     {
+-        if ($name) {
++        if ($name !== '') {
+             return 'name';
+         }
+
+         return 'no name';
+     }
+ }
+```
+
+<br>
+
+### BooleanInTernaryOperatorRuleFixerRector
+
+Fixer for PHPStan reports by strict type rule - "PHPStan\Rules\BooleansInConditions\BooleanInTernaryOperatorRule"
+
+- class: [`Rector\Strict\Rector\Ternary\BooleanInTernaryOperatorRuleFixerRector`](../rules/Strict/Rector/Ternary/BooleanInTernaryOperatorRuleFixerRector.php)
+
+```diff
+ final class ArrayCompare
+ {
+     public function run(array $data)
+     {
+-        return $data ? 1 : 2;
++        return $data !== [] ? 1 : 2;
+     }
+ }
+```
+
+<br>
+
+### DisallowedEmptyRuleFixerRector
+
+Fixer for PHPStan reports by strict type rule - "PHPStan\Rules\DisallowedConstructs\DisallowedEmptyRule"
+
+- class: [`Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector`](../rules/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector.php)
+
+```diff
+ final class SomeEmptyArray
+ {
+     public function run(array $items)
+     {
+-        return empty($items);
++        return $items === [];
+     }
+ }
+```
+
+<br>
+
+### DisallowedShortTernaryRuleFixerRector
+
+Fixer for PHPStan reports by strict type rule - "PHPStan\Rules\DisallowedConstructs\DisallowedShortTernaryRule"
+
+- class: [`Rector\Strict\Rector\Ternary\DisallowedShortTernaryRuleFixerRector`](../rules/Strict/Rector/Ternary/DisallowedShortTernaryRuleFixerRector.php)
+
+```diff
+ final class ShortTernaryArray
+ {
+     public function run(array $array)
+     {
+-        return $array ?: 2;
++        return $array !== [] ? $array : 2;
+     }
+ }
+```
+
+<br>
+
 ## Transform
 
 ### AddInterfaceByParentRector

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/BooleanInBooleanNotRuleFixerRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class BooleanInBooleanNotRuleFixerRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/negated_integer.php.inc

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class NegatedInteger
+{
+    private int $age;
+
+    public function run()
+    {
+        if (! $this->age) {
+            return 'age';
+        }
+
+        return 'no age';
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class NegatedInteger
+{
+    private int $age;
+
+    public function run()
+    {
+        if ($this->age === 0) {
+            return 'age';
+        }
+
+        return 'no age';
+    }
+}
+
+?>

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/negated_string.php.inc

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class NegatedString
+{
+    private string $name = '';
+
+    public function run()
+    {
+        if (!$this->name) {
+            return 'name';
+        }
+
+        return 'no name';
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class NegatedString
+{
+    private string $name = '';
+
+    public function run()
+    {
+        if ($this->name === '') {
+            return 'name';
+        }
+
+        return 'no name';
+    }
+}
+
+?>

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/union_null_boolean.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class UnionNullBoolean
+{
+    public function run(bool|null $maye)
+    {
+        if (! $maye) {
+            return true;
+        }
+
+        return false;
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class UnionNullBoolean
+{
+    public function run(bool|null $maye)
+    {
+        if ($maye === true) {
+            return true;
+        }
+
+        return false;
+    }
+}
+
+?>

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/union_with_null.php.inc

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class UnionWithNull
+{
+    /**
+     * @var string|null
+     */
+    private $value;
+
+    public function run()
+    {
+        if (! $this->value) {
+            return 'empty';
+        }
+
+        return 'set';
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class UnionWithNull
+{
+    /**
+     * @var string|null
+     */
+    private $value;
+
+    public function run()
+    {
+        if ($this->value === null) {
+            return 'empty';
+        }
+
+        return 'set';
+    }
+}
+
+?>

rules-tests/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/config/configured_rule.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+    $services->set(BooleanInBooleanNotRuleFixerRector::class);
+};

rules-tests/Strict/Rector/Empty_/DisallowedEmptyRuleFixerRector/DisallowedEmptyRuleFixerRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class DisallowedEmptyRuleFixerRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}