[DX] Cleanup AbstractRectorTestCase (#2882)

* remove direct symplify/smart-file-system, still transitional

* use one place of temp directory path knowledge

* comm

composer.json

@@ -41,7 +41,6 @@
         "symplify/easy-parallel": "^11.1",
         "symplify/package-builder": "dev-main",
         "symplify/rule-doc-generator-contracts": "^11.1",
-        "symplify/smart-file-system": "^11.1",
         "webmozart/assert": "^1.11"
     },
     "require-dev": {

packages/Testing/Fixture/FixtureTempFileDumper.php

@@ -15,9 +15,14 @@ final class FixtureTempFileDumper
     public static function dump(string $fileContents, string $suffix = 'php'): string
     {
         // the "php" suffix is important, because that will hook into \Rector\Core\Application\FileProcessor\PhpFileProcessor
-        $temporaryFileName = sys_get_temp_dir() . self::TEMP_FIXTURE_DIRECTORY . '/' . md5($fileContents) . '.' . $suffix;
+        $temporaryFileName = self::getTempDirectory() . '/' . md5($fileContents) . '.' . $suffix;
         FileSystem::write($temporaryFileName, $fileContents);
 
         return $temporaryFileName;
     }
+
+    public static function getTempDirectory(): string
+    {
+        return sys_get_temp_dir() . self::TEMP_FIXTURE_DIRECTORY;
+    }
 }

packages/Testing/PHPUnit/AbstractRectorTestCase.php

@@ -139,15 +139,15 @@ protected function doTestFileInfo(SmartFileInfo $fixtureFileInfo): void
 
     protected function getFixtureTempDirectory(): string
     {
-        return sys_get_temp_dir() . FixtureTempFileDumper::TEMP_FIXTURE_DIRECTORY;
+        return FixtureTempFileDumper::getTempDirectory();
     }
 
     private function resolveExpectedContents(string $filePath): string
     {
         $contents = FileSystem::read($filePath);
 
         // make sure we don't get a diff in which every line is different (because of differences in EOL)
-        return $this->normalizeNewlines($contents);
+        return str_replace("\r\n", "\n", $contents);
     }
 
     private function resolveOriginalFixtureFileSuffix(string $filePath): string
@@ -205,11 +205,6 @@ private function doTestFileMatchesExpectedContent(
         }
     }
 
-    private function normalizeNewlines(string $string): string
-    {
-        return str_replace("\r\n", "\n", $string);
-    }
-
     private function processFilePath(string $filePath): string
     {
         $this->dynamicSourceLocatorProvider->setFilePath($filePath);

packages/Testing/PHPUnit/AbstractTestCase.php

@@ -53,7 +53,7 @@ protected function bootFromConfigFiles(array $configFiles): void
     protected function getService(string $type): object
     {
         if (self::$currentContainer === null) {
-            throw new ShouldNotHappenException('First, create container with "bootWithConfigFileInfos([...])"');
+            throw new ShouldNotHappenException('First, create container with "boot()" or "bootWithConfigFileInfos([...])"');
         }
 
         $object = self::$currentContainer->get($type);