[Core] Remove loop on FilesFinder::findInDirectoriesAndFiles() (#2201)

* [Core] Remove loop on FilesFinder::findInDirectoriesAndFiles() * [ci-review] Rector Rectify * rename variable * clean up Co-authored-by: GitHub Action <action@github.com>
rectorphp · Apr 30, 2022 · c8b47df · c8b47df
1 parent f30523f
commit c8b47df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/Caching/UnchangedFilesFilter.php b/packages/Caching/UnchangedFilesFilter.php
@@ -15,7 +15,7 @@ public function __construct(
     }
 
     /**
-     * @param SmartFileInfo[] $fileInfos
+     * @param SmartFileInfo[]|string[] $fileInfos
      * @return SmartFileInfo[]
      */
     public function filterAndJoinWithDependentFileInfos(array $fileInfos): array
@@ -24,6 +24,10 @@ public function filterAndJoinWithDependentFileInfos(array $fileInfos): array
         $dependentFileInfos = [];
 
         foreach ($fileInfos as $fileInfo) {
+            if (is_string($fileInfo)) {
+                $fileInfo = new SmartFileInfo($fileInfo);
+            }
+
             if (! $this->changedFilesDetector->hasFileChanged($fileInfo)) {
                 continue;
             }

diff --git a/src/FileSystem/FilesFinder.php b/src/FileSystem/FilesFinder.php
@@ -55,12 +55,7 @@ public function findInDirectoriesAndFiles(array $source, array $suffixes = []):
 
         $directories = $this->fileSystemFilter->filterDirectories($filesAndDirectories);
 
-        $smartFileInfos = [];
-        foreach ($filePaths as $filePath) {
-            $smartFileInfos[] = new SmartFileInfo($filePath);
-        }
-
-        $smartFileInfos = $this->unchangedFilesFilter->filterAndJoinWithDependentFileInfos($smartFileInfos);
+        $smartFileInfos = $this->unchangedFilesFilter->filterAndJoinWithDependentFileInfos($filePaths);
 
         return array_merge($smartFileInfos, $this->findInDirectories($directories, $suffixes));
     }