[Php81] Skip static call in right expr of Coalesce on NewInInitialize…

…rRector (#1670)

* [Php81] Skip static call on NewInInitializerRector

* Fixed 🎉

* final touch: restructure fixtures

* final touch: eol

* use not instanceof New_ check

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_static_call_null_coalesce_operator.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
+
+use Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source\InstantiableViaNamedConstructor;
+
+final class SkipStaticCallNullCoalesceOperator
+{
+    public function __construct(private ?InstantiableViaNamedConstructor $foo = null)
+    {
+        $this->foo ??= InstantiableViaNamedConstructor::make(100);
+    }
+}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_static_call_right_coalesce.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
+
+use Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source\InstantiableViaNamedConstructor;
+
+final class SkipStaticCallRightCoalesce
+{
+    private InstantiableViaNamedConstructor $foo;
+
+    public function __construct(?InstantiableViaNamedConstructor $foo = null)
+    {
+        $this->foo = $foo ?? InstantiableViaNamedConstructor::make(100);
+    }
+
+}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Source/InstantiableViaNamedConstructor.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source;
+
+final class InstantiableViaNamedConstructor
+{
+    public static function make(int $value): InstantiableViaNamedConstructor
+    {
+        return new InstantiableViaNamedConstructor($value);
+    }
+
+    public function __construct(public int $value)
+    {
+    }
+}

rules/Php81/Rector/ClassMethod/NewInInitializerRector.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
+use PhpParser\Node\Expr\New_;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Class_;
@@ -95,6 +96,10 @@ public function refactor(Node $node): ?Node
                     continue;
                 }
 
+                if (! $toPropertyAssign->expr->right instanceof New_) {
+                    continue;
+                }
+
                 /** @var NullableType $currentParamType */
                 $currentParamType = $param->type;
                 $param->type = $currentParamType->type;