Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php81] Skip static call in right expr of Coalesce on NewInInitializerRector #1670

Merged
merged 5 commits into from
Jan 14, 2022
Merged

[Php81] Skip static call in right expr of Coalesce on NewInInitializerRector #1670

merged 5 commits into from
Jan 14, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

/cc @WesleyKlop

@samsonasik samsonasik changed the title [Php81] Skip static call on NewInInitializerRector [Php81] Skip static call in right expr of Coalesce in NewInInitializerRector Jan 14, 2022
@samsonasik samsonasik changed the title [Php81] Skip static call in right expr of Coalesce in NewInInitializerRector [Php81] Skip static call in right expr of Coalesce on NewInInitializerRector Jan 14, 2022
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit c931954 into main Jan 14, 2022
@TomasVotruba TomasVotruba deleted the skip-static-call-init branch January 14, 2022 09:21
@TomasVotruba
Copy link
Member

👍

@WesleyKlop
Copy link

Nice, that was really quick <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @WesleyKlop