Improve LocalConstantFinder performance (#3652)

* Improve LocalConstantFinder performance * simplify * typo * fix typo
rectorphp · Apr 22, 2023 · c935e91 · c935e91
1 parent 6374ccd
commit c935e91
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/PhpParser/NodeFinder/LocalConstantFinder.php b/src/PhpParser/NodeFinder/LocalConstantFinder.php
@@ -28,28 +28,28 @@ public function match(ClassConstFetch $classConstFetch): ?Const_
             return null;
         }
 
-        $constantClassType = $this->nodeTypeResolver->getType($classConstFetch->class);
-        if (! $constantClassType instanceof TypeWithClassName) {
+        $constantName = $this->nodeNameResolver->getName($classConstFetch->name);
+        if ($constantName === null) {
             return null;
         }
 
-        if (! $this->nodeNameResolver->isName($class, $constantClassType->getClassName())) {
+        $constantClassType = $this->nodeTypeResolver->getType($classConstFetch->class);
+        if (! $constantClassType instanceof TypeWithClassName) {
             return null;
         }
 
-        $constatName = $this->nodeNameResolver->getName($classConstFetch->name);
-        if ($constatName === null) {
+        if (! $this->nodeNameResolver->isName($class, $constantClassType->getClassName())) {
             return null;
         }
 
-        return $this->findConstantByName($class, $constatName);
+        return $this->findConstantByName($class, $constantName);
     }
 
-    private function findConstantByName(Class_ $class, string $constatName): ?Const_
+    private function findConstantByName(Class_ $class, string $constantName): ?Const_
     {
         foreach ($class->getConstants() as $classConsts) {
             foreach ($classConsts->consts as $const) {
-                if (! $this->nodeNameResolver->isName($const->name, $constatName)) {
+                if (! $this->nodeNameResolver->isName($const->name, $constantName)) {
                     continue;
                 }