[Privatization] Remove ReplaceStringWithClassConstantRector as rather…

… dynamic and can lead to unexpected results (#3443)
rectorphp · Mar 2, 2023 · c9a621d · c9a621d
1 parent f6305f0
commit c9a621d
Show file tree

Hide file tree

Showing 14 changed files with 3 additions and 488 deletions.
diff --git a/packages/NodeRemoval/NodeRemover.php b/packages/NodeRemoval/NodeRemover.php
@@ -39,6 +39,9 @@ public function removeNode(Node $node): void
         $this->rectorChangeCollector->notifyNodeFileInfo($node);
     }
 
+    /**
+     * @api used in rector-doctrine
+     */
     public function removeNodeFromStatements(
         Class_ | ClassMethod | Function_ $nodeWithStatements,
         Node $toBeRemovedNode

diff --git a/...StringWithClassConstantRector/CaseInsensitiveReplaceStringWithClassConstantRectorTest.php b/...StringWithClassConstantRector/CaseInsensitiveReplaceStringWithClassConstantRectorTest.php
diff --git a/...tor/MethodCall/ReplaceStringWithClassConstantRector/Fixture/replace_with_constant.php.inc b/...tor/MethodCall/ReplaceStringWithClassConstantRector/Fixture/replace_with_constant.php.inc
diff --git a/...r/MethodCall/ReplaceStringWithClassConstantRector/Fixture/skip_different_position.php.inc b/...r/MethodCall/ReplaceStringWithClassConstantRector/Fixture/skip_different_position.php.inc
diff --git a/...ClassConstantRector/FixtureCaseInsensitive/replace_with_case_insensitive_constant.php.inc b/...ClassConstantRector/FixtureCaseInsensitive/replace_with_case_insensitive_constant.php.inc
diff --git a/...hodCall/ReplaceStringWithClassConstantRector/ReplaceStringWithClassConstantRectorTest.php b/...hodCall/ReplaceStringWithClassConstantRector/ReplaceStringWithClassConstantRectorTest.php
diff --git a/...sts/Privatization/Rector/MethodCall/ReplaceStringWithClassConstantRector/Source/Order.php b/...sts/Privatization/Rector/MethodCall/ReplaceStringWithClassConstantRector/Source/Order.php
diff --git a/...ivatization/Rector/MethodCall/ReplaceStringWithClassConstantRector/Source/Placeholder.php b/...ivatization/Rector/MethodCall/ReplaceStringWithClassConstantRector/Source/Placeholder.php
diff --git a/...odCall/ReplaceStringWithClassConstantRector/config/case_insensitive_configured_config.php b/...odCall/ReplaceStringWithClassConstantRector/config/case_insensitive_configured_config.php
diff --git a/...ation/Rector/MethodCall/ReplaceStringWithClassConstantRector/config/configured_config.php b/...ation/Rector/MethodCall/ReplaceStringWithClassConstantRector/config/configured_config.php
diff --git a/rules/Privatization/NodeFactory/ClassConstantFetchValueFactory.php b/rules/Privatization/NodeFactory/ClassConstantFetchValueFactory.php