Apply Rector + coding standard (#3745)

rectorphp · May 6, 2023 · d13351c · d13351c
1 parent 575e799
commit d13351c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 13 deletions.
diff --git a/packages/NodeTypeResolver/NodeTypeResolver.php b/packages/NodeTypeResolver/NodeTypeResolver.php
@@ -13,7 +13,6 @@
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Ternary;
-use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\NullableType;

diff --git a/packages/Parallel/WorkerRunner.php b/packages/Parallel/WorkerRunner.php
@@ -173,7 +173,7 @@ private function collectSystemErrors(array $systemErrors, Throwable $throwable,
 
     private function invalidateFile(?File $file): void
     {
-        if (!$file instanceof File) {
+        if (! $file instanceof File) {
             return;
         }
 

diff --git a/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToArrayFilterRector.php b/rules/CodeQuality/Rector/Foreach_/SimplifyForeachToArrayFilterRector.php
@@ -133,7 +133,8 @@ private function shouldSkip(Foreach_ $foreach): bool
         }
 
         $type = $this->getType($foreach->expr);
-        return ! $type->isArray()->yes();
+        return ! $type->isArray()
+            ->yes();
     }
 
     private function shouldSkipForeachKeyUsage(If_ $if, Expr $expr): bool

diff --git a/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php b/rules/Php71/Rector/FuncCall/RemoveExtraParametersRector.php
@@ -113,8 +113,8 @@ private function shouldSkipFunctionReflection(MethodReflection|FunctionReflectio
         }
 
         if ($reflection instanceof MethodReflection) {
-            $class = $reflection->getDeclaringClass();
-            $fileName = (string) $class->getFileName();
+            $classReflection = $reflection->getDeclaringClass();
+            $fileName = (string) $classReflection->getFileName();
             if (str_contains($fileName, 'phpstan.phar')) {
                 return \true;
             }

diff --git a/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php b/rules/Restoration/Rector/Class_/RemoveFinalFromEntityRector.php
@@ -20,18 +20,12 @@ final class RemoveFinalFromEntityRector extends AbstractRector
     /**
      * @var string[]
      */
-    private const ALLOWED_ANNOTATIONS = [
-        'Doctrine\ORM\Mapping\Entity',
-        'Doctrine\ORM\Mapping\Embeddable'
-    ];
+    private const ALLOWED_ANNOTATIONS = ['Doctrine\ORM\Mapping\Entity', 'Doctrine\ORM\Mapping\Embeddable'];
 
     /**
      * @var string[]
      */
-    private const ALLOWED_ATTRIBUTES = [
-        'Doctrine\ORM\Mapping\Entity',
-        'Doctrine\ORM\Mapping\Embeddable'
-    ];
+    private const ALLOWED_ATTRIBUTES = ['Doctrine\ORM\Mapping\Entity', 'Doctrine\ORM\Mapping\Embeddable'];
 
     public function __construct(
         private readonly VisibilityManipulator $visibilityManipulator,