[CodeQuality] Skip static class const fetch on InlineConstructorDefau…

…ltToPropertyRector (#3510)

* [CodeQuality] Skip static class const fetch on InlineConstructorDefaultToPropertyRector

* [ci-review] Rector Rectify

* Fixed 🎉

---------

Co-authored-by: GitHub Action <actions@github.com>

packages/NodeNameResolver/NodeNameResolver.php

@@ -29,6 +29,7 @@ final class NodeNameResolver
      * @see https://regex101.com/r/ImTV1W/1
      */
     private const CONTAINS_WILDCARD_CHARS_REGEX = '/[\*\#\~\/]/';
+
     /**
      * @var array<string, NodeNameResolverInterface|null>
      */

rules-tests/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector/Fixture/skip_static_class_const_fetch2.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector\Fixture;
+
+final class SkipStaticClassConstFetch2
+{
+    private $name;
+
+    private const NUMBER = 1;
+
+    public function __construct()
+    {
+        $this->name = static::NUMBER;
+    }
+}

src/NodeAnalyzer/ExprAnalyzer.php

@@ -95,10 +95,6 @@ private function isAllowedConstFetchOrClassConstFetch(Expr $expr): bool
                 return false;
             }
 
-            if ($expr->name->toString() !== 'class') {
-                return true;
-            }
-
             // static::class cannot be used for compile-time class name resolution
             return $expr->class->toString() !== ObjectReference::STATIC;
         }