Skip to content

Commit

Permalink
[EarlyReturn] Remove ReturnBinaryAndToEarlyReturnRector as creates co…
Browse files Browse the repository at this point in the history
…de hard to read and flips condition (#4478)
  • Loading branch information
TomasVotruba committed Jul 11, 2023
1 parent 59b4c8d commit db16e33
Show file tree
Hide file tree
Showing 19 changed files with 2 additions and 636 deletions.
27 changes: 2 additions & 25 deletions build/target-repository/docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
# 362 Rules Overview
# 361 Rules Overview

<br>

Expand All @@ -12,7 +12,7 @@

- [DeadCode](#deadcode) (42)

- [EarlyReturn](#earlyreturn) (10)
- [EarlyReturn](#earlyreturn) (9)

- [Naming](#naming) (6)

Expand Down Expand Up @@ -3377,29 +3377,6 @@ Split if statement, when if condition always break execution flow

<br>

### ReturnBinaryAndToEarlyReturnRector

Changes Single return of && to early returns

- class: [`Rector\EarlyReturn\Rector\Return_\ReturnBinaryAndToEarlyReturnRector`](../rules/EarlyReturn/Rector/Return_/ReturnBinaryAndToEarlyReturnRector.php)

```diff
class SomeClass
{
public function accept()
{
- return $this->something() && $this->somethingelse();
+ if (! $this->something()) {
+ return false;
+ }
+
+ return (bool) $this->somethingelse();
}
}
```

<br>

### ReturnBinaryOrToEarlyReturnRector

Changes Single return of || to early returns
Expand Down
2 changes: 0 additions & 2 deletions config/set/early-return.php
Expand Up @@ -10,7 +10,6 @@
use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\EarlyReturn\Rector\Return_\ReturnBinaryAndToEarlyReturnRector;
use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;

Expand All @@ -21,7 +20,6 @@
ChangeIfElseValueAssignToEarlyReturnRector::class,
ChangeNestedIfsToEarlyReturnRector::class,
RemoveAlwaysElseRector::class,
ReturnBinaryAndToEarlyReturnRector::class,
ChangeOrIfContinueToMultiContinueRector::class,
PreparedValueToEarlyReturnRector::class,
ReturnBinaryOrToEarlyReturnRector::class,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit db16e33

Please sign in to comment.