[PHP 8.0] Add DoctrineAnnotationClassToAttributeRector (#78)

packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php

@@ -24,7 +24,12 @@ final class PhpAttributeGroupFactory
 {
     public function createFromSimpleTag(AnnotationToAttribute $annotationToAttribute): AttributeGroup
     {
-        $fullyQualified = new FullyQualified($annotationToAttribute->getAttributeClass());
+        return $this->createFromClass($annotationToAttribute->getAttributeClass());
+    }
+
+    public function createFromClass(string $attributeClass): AttributeGroup
+    {
+        $fullyQualified = new FullyQualified($attributeClass);
         $attribute = new Attribute($fullyQualified);
         return new AttributeGroup([$attribute]);
     }

phpstan.neon

@@ -479,3 +479,7 @@ parameters:
         -
             message: '#Do not use chained method calls#'
             path: packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php
+
+        -
+            message: '#Function "dump_node\(\)" cannot be used/left in the code#'
+            path: src/functions/node_helper.php

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/DoctrineAnnotationClassToAttributeRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class DoctrineAnnotationClassToAttributeRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/Fixture/none_target.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+/**
+ * @Annotation
+ */
+final class NoneTarget
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+#[\Attribute]
+final class NoneTarget
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/Fixture/required_value.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Required;
+
+/**
+ * @annotation
+ */
+final class RequiredValue
+{
+    /** @Required */
+    public $requiredField;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Required;
+
+#[\Attribute]
+final class RequiredValue
+{
+    public function __construct(public $requiredField)
+    {
+    }
+}
+
+?>

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/Fixture/some_class.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Target;
+
+/**
+ * @Annotation
+ * @Target({"METHOD"})
+ */
+class SomeAnnotation
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Target;
+
+#[\Attribute(\Attribute::TARGET_METHOD)]
+class SomeAnnotation
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/Fixture/target_method_property_class.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Target;
+
+/**
+ * @Annotation
+ * @Target({"METHOD", "PROPERTY", "CLASS"})
+ */
+final class TargetMethodPropertyClass
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector\Fixture;
+
+use Doctrine\Common\Annotations\Annotation\Target;
+
+#[\Attribute(\Attribute::TARGET_METHOD | \Attribute::TARGET_PROPERTY | \Attribute::TARGET_CLASS)]
+final class TargetMethodPropertyClass
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/DoctrineAnnotationClassToAttributeRector/config/configured_rule.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Php80\Rector\Class_\DoctrineAnnotationClassToAttributeRector;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+    $services->set(DoctrineAnnotationClassToAttributeRector::class);
+};

rules/Arguments/Rector/MethodCall/ValueObjectWrapArgRector.php

@@ -19,6 +19,7 @@
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Arguments\Rector\MethodCall\ValueObjectWrapArgRector\ValueObjectWrapArgRectorTest
@@ -111,7 +112,10 @@ public function refactor(Node $node): ?Node
      */
     public function configure(array $configuration): void
     {
-        $this->valueObjectWrapArgs = $configuration[self::VALUE_OBJECT_WRAP_ARGS] ?? [];
+        $valueObjectWrapArgs = $configuration[self::VALUE_OBJECT_WRAP_ARGS] ?? [];
+        Assert::allIsInstanceOf($valueObjectWrapArgs, ValueObjectWrapArg::class);
+
+        $this->valueObjectWrapArgs = $valueObjectWrapArgs;
     }
 
     private function wrapInNewWithType(ObjectType $newObjectType, Expr $expr): New_

rules/Composer/Rector/AddPackageToRequireComposerRector.php

@@ -10,6 +10,7 @@
 use Symplify\ComposerJsonManipulator\ValueObject\ComposerJson;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Composer\Rector\AddPackageToRequireComposerRector\AddPackageToRequireComposerRectorTest
@@ -67,6 +68,8 @@ public function getRuleDefinition(): RuleDefinition
     public function configure(array $configuration): void
     {
         $packagesAndVersions = $configuration[self::PACKAGES_AND_VERSIONS] ?? [];
+        Assert::allIsInstanceOf($packagesAndVersions, PackageAndVersion::class);
+
         $this->versionGuard->validate($packagesAndVersions);
         $this->packagesAndVersions = $packagesAndVersions;
     }

rules/Composer/Rector/AddPackageToRequireDevComposerRector.php

@@ -10,6 +10,7 @@
 use Symplify\ComposerJsonManipulator\ValueObject\ComposerJson;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Composer\Rector\AddPackageToRequireDevComposerRector\AddPackageToRequireDevComposerRectorTest
@@ -70,6 +71,8 @@ public function getRuleDefinition(): RuleDefinition
     public function configure(array $configuration): void
     {
         $packagesAndVersions = $configuration[self::PACKAGES_AND_VERSIONS] ?? [];
+        Assert::allIsInstanceOf($packagesAndVersions, PackageAndVersion::class);
+
         $this->versionGuard->validate($packagesAndVersions);
         $this->packageAndVersions = $packagesAndVersions;
     }

rules/Composer/Rector/ChangePackageVersionComposerRector.php

@@ -10,6 +10,7 @@
 use Symplify\ComposerJsonManipulator\ValueObject\ComposerJson;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Composer\Rector\ChangePackageVersionComposerRector\ChangePackageVersionComposerRectorTest
@@ -73,6 +74,8 @@ public function getRuleDefinition(): RuleDefinition
     public function configure(array $configuration): void
     {
         $packagesAndVersions = $configuration[self::PACKAGES_AND_VERSIONS] ?? [];
+        Assert::allIsInstanceOf($packagesAndVersions, PackageAndVersion::class);
+
         $this->versionGuard->validate($packagesAndVersions);
         $this->packagesAndVersions = $packagesAndVersions;
     }

rules/Composer/Rector/RenamePackageComposerRector.php

@@ -9,6 +9,7 @@
 use Symplify\ComposerJsonManipulator\ValueObject\ComposerJson;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Composer\Rector\RenamePackageComposerRector\RenamePackageComposerRectorTest
@@ -78,6 +79,8 @@ public function getRuleDefinition(): RuleDefinition
      */
     public function configure(array $configuration): void
     {
-        $this->renamePackages = $configuration[self::RENAME_PACKAGES] ?? [];
+        $renamePackages = $configuration[self::RENAME_PACKAGES] ?? [];
+        Assert::allIsInstanceOf($renamePackages, RenamePackage::class);
+        $this->renamePackages = $renamePackages;
     }
 }

rules/Composer/Rector/ReplacePackageAndVersionComposerRector.php

@@ -10,6 +10,7 @@
 use Symplify\ComposerJsonManipulator\ValueObject\ComposerJson;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Composer\Rector\ReplacePackageAndVersionComposerRector\ReplacePackageAndVersionComposerRectorTest
@@ -78,6 +79,8 @@ public function getRuleDefinition(): RuleDefinition
     public function configure(array $configuration): void
     {
         $replacePackagesAndVersions = $configuration[self::REPLACE_PACKAGES_AND_VERSIONS] ?? [];
+        Assert::allIsInstanceOf($replacePackagesAndVersions, ReplacePackageAndVersion::class);
+
         $this->versionGuard->validate($replacePackagesAndVersions);
         $this->replacePackagesAndVersions = $replacePackagesAndVersions;
     }