Fixed constant types handling in TypedPropertyFromStrictConstructorRe…

…ctor (#4588)

* Fixed constant-literal handling in TypedPropertyFromStrictConstructorRector

* fix

* add analog test to TypedPropertyFromStrictConstructorReadonlyClassRector

rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_incompatible_type.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorReadonlyClassRector\Fixture;
+
+final class SkipLiteralIncompatibleType
+{
+    /**
+     * @var string
+     */
+    public $due_date;
+
+    public function __construct()
+    {
+        $this->due_date = true;
+    }
+}

rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorReadonlyClassRector/Fixture/skip_literal_string_type.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorReadonlyClassRector\Fixture;
+
+final class SkipLiteralStringType
+{
+    /**
+     * @var string
+     */
+    public $due_date;
+
+    public function __construct()
+    {
+        $this->due_date = '';
+    }
+}

rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector/Fixture/skip_literal_incompatible_type.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector\Fixture;
+
+final class SkipLiteralIncompatibleType
+{
+    /**
+     * @var string
+     */
+    public $due_date;
+
+    public function __construct()
+    {
+        $this->due_date = true;
+    }
+}

rules-tests/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector/Fixture/skip_literal_string_type.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector\Fixture;
+
+final class SkipLiteralStringType
+{
+    /**
+     * @var string
+     */
+    public $due_date;
+
+    public function __construct()
+    {
+        $this->due_date = '';
+    }
+}

rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php

@@ -118,6 +118,11 @@ public function refactor(Node $node): ?Node
 
             // public property can be anything
             if ($property->isPublic()) {
+                if (!$phpDocInfo->getVarType() instanceof MixedType) {
+                    continue;
+                }
+
+
                 $this->phpDocTypeChanger->changeVarType($property, $phpDocInfo, $propertyType);
                 $hasChanged = true;
                 continue;