Skip to content

Commit

Permalink
[code-quality] Remove intval/strval from sets, as no clear difference…
Browse files Browse the repository at this point in the history
… and personal preference (#5721)
  • Loading branch information
TomasVotruba committed Mar 14, 2024
1 parent b870d8f commit ea0f1c1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 0 additions & 4 deletions config/set/code-quality.php
Expand Up @@ -33,7 +33,6 @@
use Rector\CodeQuality\Rector\FuncCall\CompactToVariablesRector;
use Rector\CodeQuality\Rector\FuncCall\FloatvalToTypeCastRector;
use Rector\CodeQuality\Rector\FuncCall\InlineIsAInstanceOfRector;
use Rector\CodeQuality\Rector\FuncCall\IntvalToTypeCastRector;
use Rector\CodeQuality\Rector\FuncCall\IsAWithStringWithThirdArgumentRector;
use Rector\CodeQuality\Rector\FuncCall\RemoveSoleValueSprintfRector;
use Rector\CodeQuality\Rector\FuncCall\SetTypeToCastRector;
Expand All @@ -42,7 +41,6 @@
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
use Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector;
use Rector\CodeQuality\Rector\FuncCall\StrvalToTypeCastRector;
use Rector\CodeQuality\Rector\FuncCall\UnwrapSprintfOneArgumentRector;
use Rector\CodeQuality\Rector\FunctionLike\SimplifyUselessVariableRector;
use Rector\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector;
Expand Down Expand Up @@ -142,7 +140,6 @@
SimplifyBoolIdenticalTrueRector::class,
SimplifyRegexPatternRector::class,
BooleanNotIdenticalToNotIdenticalRector::class,
StrvalToTypeCastRector::class,
FloatvalToTypeCastRector::class,
CallableThisArrayToAnonymousFunctionRector::class,
AndAssignsToSeparateLinesRector::class,
Expand All @@ -154,7 +151,6 @@
RemoveSoleValueSprintfRector::class,
ShortenElseIfRector::class,
ArrayMergeOfNonArraysToSimpleArrayRector::class,
IntvalToTypeCastRector::class,
BoolvalToTypeCastRector::class,
ArrayKeyExistsTernaryThenValueToCoalescingRector::class,
AbsolutizeRequireAndIncludePathRector::class,
Expand Down
4 changes: 4 additions & 0 deletions utils/Command/MissingInSetCommand.php
Expand Up @@ -5,6 +5,8 @@
namespace Rector\Utils\Command;

use Nette\Utils\Strings;
use Rector\CodeQuality\Rector\FuncCall\IntvalToTypeCastRector;
use Rector\CodeQuality\Rector\FuncCall\StrvalToTypeCastRector;
use Rector\CodingStyle\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector;
use Rector\Contract\Rector\ConfigurableRectorInterface;
use Rector\DeadCode\Rector\ClassMethod\RemoveNullTagValueNodeRector;
Expand Down Expand Up @@ -34,6 +36,8 @@ final class MissingInSetCommand extends Command
// optional
BinaryOpNullableToInstanceofRector::class,
WhileNullableToInstanceofRector::class,
IntvalToTypeCastRector::class,
StrvalToTypeCastRector::class,
// changes behavior, should be applied on purpose regardless PHP 7.3 level
JsonThrowOnErrorRector::class,
// in confront with sub type safe belt detection on RemoveUseless*TagRector
Expand Down

0 comments on commit ea0f1c1

Please sign in to comment.