Defer type-resolving in SideEffectNodeDetector (#3762)

rectorphp · May 7, 2023 · ea3d4f1 · ea3d4f1
1 parent ce46293
commit ea3d4f1
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/rules/DeadCode/SideEffect/SideEffectNodeDetector.php b/rules/DeadCode/SideEffect/SideEffectNodeDetector.php
@@ -53,17 +53,17 @@ public function detect(Expr $expr): bool
             return true;
         }
 
-        $exprStaticType = $this->nodeTypeResolver->getType($expr);
-        if ($exprStaticType instanceof ConstantType) {
-            return false;
-        }
-
         foreach (self::SIDE_EFFECT_NODE_TYPES as $sideEffectNodeType) {
             if ($expr instanceof $sideEffectNodeType) {
                 return false;
             }
         }
 
+        $exprStaticType = $this->nodeTypeResolver->getType($expr);
+        if ($exprStaticType instanceof ConstantType) {
+            return false;
+        }
+
         if ($expr instanceof FuncCall) {
             return ! $this->pureFunctionDetector->detect($expr);
         }