Defer type-resolving in ForeachToInArrayRector (#3756)

rectorphp · May 7, 2023 · ce46293 · ce46293
1 parent 0f07aac
commit ce46293
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php b/rules/CodeQuality/Rector/Foreach_/ForeachToInArrayRector.php
@@ -139,6 +139,10 @@ private function shouldSkipForeach(Foreach_ $foreach): bool
             return true;
         }
 
+        if (!$foreach->stmts[0] instanceof If_) {
+            return true;
+        }
+
         $nextNode = $foreach->getAttribute(AttributeKey::NEXT_NODE);
         if (! $nextNode instanceof Node) {
             return true;
@@ -149,7 +153,6 @@ private function shouldSkipForeach(Foreach_ $foreach): bool
         }
 
         $returnExpression = $nextNode->expr;
-
         if (! $returnExpression instanceof Expr) {
             return true;
         }
@@ -163,7 +166,7 @@ private function shouldSkipForeach(Foreach_ $foreach): bool
             return true;
         }
 
-        return ! $foreach->stmts[0] instanceof If_;
+        return false;
     }
 
     private function shouldSkipIf(If_ $if): bool