[PHP 8.1] Do not process static methods from Enum class (#2911)

* Do not process static methods from Enum class

* Properly handle case where result of the method is further accessed (chain call).

* keep FQN class names by convention

* [ci-review] Rector Rectify

Co-authored-by: xrogers <xrogers@gmail.com>
Co-authored-by: GitHub Action <action@github.com>

rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/fully_qualified_class_name.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Fixture;
+
+use \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector;
+
+final class FullyQualifiedClassName
+{
+    public function run($value)
+    {
+        $compare = \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum::USED_TO_BE_CONST();
+        $compare2 = MyCLabsMethodCallToEnumConstRector\Source\SomeEnum::USED_TO_BE_CONST();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Fixture;
+
+use \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector;
+
+final class FullyQualifiedClassName
+{
+    public function run($value)
+    {
+        $compare = \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum::USED_TO_BE_CONST;
+        $compare2 = \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum::USED_TO_BE_CONST;
+    }
+}
+
+?>

rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/skip_enum_static_method_call.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Fixture;
+
+use Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum;
+
+final class StaticEnumStaticMethodCall
+{
+    public function run($value)
+    {
+        SomeEnum::from($value)->getKey();
+        SomeEnum::from($value)->getValue();
+        $compare = SomeEnum::from($value);
+        $compare = SomeEnum::values();
+        $compare = SomeEnum::keys();
+        $compare = SomeEnum::isValid($value);
+        $compare = SomeEnum::search($value);
+        $compare = SomeEnum::toArray();
+        SomeEnum::assertValidValue($value);
+    }
+}

rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/Fixture/usage_of_get_value.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Fixture;
+
+use Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum;
+
+final class UsageOfGetValue
+{
+    public function run($value)
+    {
+        $enum = SomeEnum::USED_TO_BE_CONST()->getValue();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Fixture;
+
+use Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum;
+
+final class UsageOfGetValue
+{
+    public function run($value)
+    {
+        $enum = \Rector\Tests\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector\Source\SomeEnum::USED_TO_BE_CONST->value;
+    }
+}
+
+?>

rules-tests/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector/MyCLabsMethodCallToEnumConstRectorTest.php

@@ -17,9 +17,6 @@ public function test(string $filePath): void
         $this->doTestFile($filePath);
     }
 
-    /**
-     * @return Iterator<array<string>>
-     */
     public function provideData(): Iterator
     {
         return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');

rules/Php81/Rector/MethodCall/MyCLabsMethodCallToEnumConstRector.php

@@ -25,6 +25,11 @@
  */
 final class MyCLabsMethodCallToEnumConstRector extends AbstractRector implements MinPhpVersionInterface
 {
+    /**
+     * @var string[]
+     */
+    private const ENUM_METHODS = ['from', 'values', 'keys', 'isValid', 'search', 'toArray', 'assertValidValue'];
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Refactor MyCLabs enum fetch to Enum const', [
@@ -63,6 +68,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($this->shouldOmitEnumCase($enumCaseName)) {
+            return null;
+        }
+
         if ($node instanceof MethodCall) {
             return $this->refactorMethodCall($node, $enumCaseName);
         }
@@ -101,6 +110,10 @@ private function refactorGetKeyMethodCall(MethodCall $methodCall): ?ClassConstFe
             return null;
         }
 
+        if ($this->shouldOmitEnumCase($enumCaseName)) {
+            return null;
+        }
+
         return $this->nodeFactory->createClassConstFetch($className, $enumCaseName);
     }
 
@@ -121,6 +134,10 @@ private function refactorGetValueMethodCall(MethodCall $methodCall): ?PropertyFe
             return null;
         }
 
+        if ($this->shouldOmitEnumCase($enumCaseName)) {
+            return null;
+        }
+
         $enumConstFetch = $this->nodeFactory->createClassConstFetch($className, $enumCaseName);
 
         return new PropertyFetch($enumConstFetch, 'value');
@@ -142,4 +159,9 @@ private function refactorMethodCall(MethodCall $methodCall, string $methodName):
 
         return null;
     }
+
+    private function shouldOmitEnumCase(string $enumCaseName): bool
+    {
+        return in_array($enumCaseName, self::ENUM_METHODS, true);
+    }
 }