Remove RemoveOverriddenValuesRector as flow of control is not reliabl…

…e and could cause invalid removal (#2614)
rectorphp · Jul 3, 2022 · f608461 · f608461
1 parent 5972ff7
commit f608461
Show file tree

Hide file tree

Showing 32 changed files with 452 additions and 1,503 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
diff --git a/config/set/dead-code.php b/config/set/dead-code.php
@@ -31,7 +31,6 @@
 use Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector;
 use Rector\DeadCode\Rector\FunctionLike\RemoveDeadReturnRector;
 use Rector\DeadCode\Rector\FunctionLike\RemoveDuplicatedIfReturnRector;
-use Rector\DeadCode\Rector\FunctionLike\RemoveOverriddenValuesRector;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 use Rector\DeadCode\Rector\If_\RemoveUnusedNonEmptyArrayBeforeForeachRector;
 use Rector\DeadCode\Rector\If_\SimplifyIfElseWithSameContentRector;
@@ -62,7 +61,6 @@
         RemoveEmptyClassMethodRector::class,
         RemoveDoubleAssignRector::class,
         SimplifyMirrorAssignRector::class,
-        RemoveOverriddenValuesRector::class,
         RemoveUnusedPrivatePropertyRector::class,
         RemoveUnusedPrivateClassConstantRector::class,
         RemoveUnusedPrivateMethodRector::class,

diff --git a/packages/NodeNestingScope/FlowOfControlLocator.php b/packages/NodeNestingScope/FlowOfControlLocator.php
diff --git a/...s-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/fixture.php.inc b/...s-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/fixture.php.inc
diff --git a/...-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/function.php.inc b/...-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/function.php.inc
diff --git a/rules-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep.php.inc b/rules-tests/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep.php.inc
diff --git a/...ector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_conditional_override.php.inc b/...ector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_conditional_override.php.inc
diff --git a/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_pre_assign.php.inc b/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_pre_assign.php.inc
diff --git a/...Code/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_presenter_name.php.inc b/...Code/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_presenter_name.php.inc
diff --git a/...sts/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_re_use.php.inc b/...sts/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_re_use.php.inc
diff --git a/...s/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_re_use_2.php.inc b/...s/DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/keep_re_use_2.php.inc
diff --git a/...emoveOverriddenValuesRector/Fixture/keep_same_level_but_different_condition_scope.php.inc b/...emoveOverriddenValuesRector/Fixture/keep_same_level_but_different_condition_scope.php.inc
diff --git a/...eadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/multiple_assigns.php.inc b/...eadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/multiple_assigns.php.inc
diff --git a/.../Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_assign_method_call.php.inc b/.../Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_assign_method_call.php.inc
diff --git a/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_issue_1093.php.inc b/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_issue_1093.php.inc
diff --git a/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_issue_1286.php.inc b/...DeadCode/Rector/FunctionLike/RemoveOverriddenValuesRector/Fixture/skip_issue_1286.php.inc