[DeadCode] Fix non-null type check on RemoveUnusedNonEmptyArrayBefore…

…ForeachRector (#430)
rectorphp · Jul 13, 2021 · f7eeeba · f7eeeba
1 parent 7bb957d
commit f7eeeba
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/rules/DeadCode/UselessIfCondBeforeForeachDetector.php b/rules/DeadCode/UselessIfCondBeforeForeachDetector.php
@@ -62,13 +62,7 @@ public function isMatchingNotEmpty(If_ $if, Expr $foreachExpr): bool
             return true;
         }
 
-        return $this->isNullableParam($previousParam);
-    }
-
-    public function isNullableParam(Param $param): bool
-    {
-        $type = $this->nodeTypeResolver->resolve($param->var);
-        return $type instanceof NullableType;
+        return ! $previousParam->type instanceof NullableType;
     }
 
     /**