deprecated return/property type declarations that work with non-relia…

…ble doblocks
rectorphp · Nov 27, 2022 · f8b847f · f8b847f
1 parent 37ec50e
commit f8b847f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/rules/Php74/Rector/Property/TypedPropertyRector.php b/rules/Php74/Rector/Property/TypedPropertyRector.php
@@ -34,6 +34,9 @@
  *
  * @see \Rector\Tests\Php74\Rector\Property\TypedPropertyRector\TypedPropertyRectorTest
  * @see \Rector\Tests\Php74\Rector\Property\TypedPropertyRector\ImportedTest
+ *
+ * @deprecated Moving doc types to type declarations is dangerous. Use specific strict types instead.
+ * This rule will be split info many small ones.
  */
 final class TypedPropertyRector extends AbstractScopeAwareRector implements AllowEmptyConfigurableRectorInterface, MinPhpVersionInterface
 {

diff --git a/rules/TypeDeclaration/Contract/TypeInferer/ReturnTypeInfererInterface.php b/rules/TypeDeclaration/Contract/TypeInferer/ReturnTypeInfererInterface.php
@@ -8,6 +8,10 @@
 use PHPStan\Type\Type;
 use Rector\TypeDeclaration\Contract\PriorityAwareInterface;
 
+/**
+ * @deprecated These inferers are complex and work with non-reliable docblocks.
+ * Instead split them to specific rules that work with strict types.
+ */
 interface ReturnTypeInfererInterface extends PriorityAwareInterface
 {
     public function inferFunctionLike(FunctionLike $functionLike): Type;

diff --git a/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php
@@ -64,7 +64,7 @@ public function refactor(Node $node): ?Node
     {
         trigger_error(
             'Use specific rules to infer params instead. This rule will was split info many small ones.',
-            E_WARNING
+            E_ERROR
         );
         sleep(3);
 

diff --git a/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/FunctionLike/ReturnTypeDeclarationRector.php
@@ -38,6 +38,9 @@
  * @changelog https://wiki.php.net/rfc/scalar_type_hints_v5
  *
  * @see \Rector\Tests\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector\ReturnTypeDeclarationRectorTest
+ *
+ * @deprecated Moving doc types to type declarations is dangerous. Use specific strict types instead.
+ * This rule will be split info many small ones.
  */
 final class ReturnTypeDeclarationRector extends AbstractRector implements MinPhpVersionInterface
 {