Remove resolveFromNodeWithScopeCountAndFallbackName() as unused (#4652)

rectorphp · Aug 4, 2023 · fbcd7cf · fbcd7cf
1 parent cbc026e
commit fbcd7cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 25 deletions.
diff --git a/packages/Testing/Fixture/FixtureFileFinder.php b/packages/Testing/Fixture/FixtureFileFinder.php
@@ -17,7 +17,8 @@ public static function yieldDirectory(string $directory, string $suffix = '*.php
         $finder = (new Finder())
             ->in($directory)
             ->files()
-            ->name($suffix);
+            ->name($suffix)
+            ->sortByName();
 
         foreach ($finder as $fileInfo) {
             yield [$fileInfo->getRealPath()];

diff --git a/rules/Naming/Naming/VariableNaming.php b/rules/Naming/Naming/VariableNaming.php
@@ -4,18 +4,15 @@
 
 namespace Rector\Naming\Naming;
 
-use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Arg;
-use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Cast;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\NullsafeMethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Scalar\String_;
-use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
 use PHPStan\Type\ThisType;
 use PHPStan\Type\Type;
@@ -45,27 +42,6 @@ public function __construct(
         ];
     }
 
-    /**
-     * @api
-     */
-    public function resolveFromNodeWithScopeCountAndFallbackName(
-        Expr $expr,
-        MutatingScope $mutatingScope,
-        string $fallbackName
-    ): string {
-        $name = $this->resolveFromNode($expr);
-        if ($name === null) {
-            $name = $fallbackName;
-        }
-
-        if (\str_contains($name, '\\')) {
-            $name = (string) Strings::after($name, '\\', -1);
-        }
-
-        $countedValueName = $this->createCountedValueName($name, $mutatingScope);
-        return lcfirst($countedValueName);
-    }
-
     public function createCountedValueName(string $valueName, ?Scope $scope): string
     {
         if (! $scope instanceof Scope) {