Fix performance issue

[ossinkine]

I faced with performance issue on my project. When I run rector process on big number of files it takes a lot of time. I profiled this command and found that NodeScopeResolver is decorated on each node processing. As result there is a huge staketrace:

I moved decoration to constructor to do it once and it boost performance a lot.

[ossinkine]

Looks like tests failing is not related to my changes

[TomasVotruba]

This would be a great improvement 👍

What are the before/after numbers on how big project?

[ossinkine]

We have about 4k files. Before it takes about 30 minutes and sometime was freezes and after about 6 minutes.

[TomasVotruba]

I've retriggered the CI, but it seems to fail because of this change.

The CI is passing well, at least 1 minute ago: #2775

[TomasVotruba]

We have about 4k files. Before it takes about 30 minutes and sometime was freezes and after about 6 minutes.

Wow, that's amazing 😮

[ossinkine]

I rebased my branch onto main and tests have passed

[TomasVotruba]

Thanks you 👍 Let's get this to main, I'm eager to try it out 😄

[TomasVotruba]

I tried it on Symplify project and both before/after this change take 30 seconds.

Probably depends on used autoload paths. Could you share your rector.php config?

[samsonasik]

Looking at last 2 downgrade builds for rector-src in main branch for source + vendor, they seems faster (only 3 minutes) which seems means there is speed improvement

[TomasVotruba]

Could you link those builds? I'd like to check

[samsonasik]

I probably was miss click, its there:

• https://github.com/rectorphp/rector-src/runs/7898072185?check_suite_focus=true ( 3m 39s)

• https://github.com/rectorphp/rector-src/runs/7898989922?check_suite_focus=true( 3m 5s)

[TomasVotruba]

Interesting... 👏 a week ago it was even 4:20

• https://github.com/rectorphp/rector-src/runs/7764010585?check_suite_focus=true

[ossinkine]

Hi @TomasVotruba,

I'm, using the following config:

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->paths([
        __DIR__.'/src',
        __DIR__.'/tests',
    ]);

    $rectorConfig->symfonyContainerXml(__DIR__.'/var/cache/test/App_KernelTestDebugContainer.xml');
    $rectorConfig->importNames();
    $rectorConfig->importShortClasses(false);
    $rectorConfig->disableParallel();

    // PHP
    $rectorConfig->import(LevelSetList::UP_TO_PHP_81);
    $rectorConfig->import(SetList::CODE_QUALITY);
    $rectorConfig->import(SetList::DEAD_CODE);
    $rectorConfig->import(SetList::TYPE_DECLARATION_STRICT);

    // Symfony
    $rectorConfig->import(SymfonyLevelSetList::UP_TO_SYMFONY_54);
    $rectorConfig->import(SymfonySetList::SYMFONY_STRICT);

    // Doctrine
    $rectorConfig->import(DoctrineSetList::DOCTRINE_ORM_29);
    $rectorConfig->import(DoctrineSetList::DOCTRINE_CODE_QUALITY);
    $rectorConfig->import(DoctrineSetList::ANNOTATIONS_TO_ATTRIBUTES);

    // PHPUnit
    $rectorConfig->import(PHPUnitLevelSetList::UP_TO_PHPUNIT_90);
    $rectorConfig->import(PHPUnitSetList::PHPUNIT_CODE_QUALITY);
    $rectorConfig->import(PHPUnitSetList::PHPUNIT_EXCEPTION);
    $rectorConfig->import(PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD);
};

[TomasVotruba]

Thanks for sharing 👍

It seems quite rich on sets 💪
I think the performance boost will be most likely connected with your exact codebase.

[ossinkine]

@TomasVotruba Are you going to release this?

[TomasVotruba]

Yes :)
We usually release once a 2-3 weeks, when we collect more features and bug fixes.

[pheller24]

Hey, I just wanted to leave my feedback here: really nice improvement, our CI step went from ~10m to under 5min. Even the 🌳 🌲 🌴 love your work (both of you)

[TomasVotruba]

@pheller24 Thank you for reaching out 👍 ❤️

I love to see huge improvements... all credit goes to @ossinkine 🙏