Prove bug with inverseJoinColumns

[fezfez]

No description provided.

[samsonasik]

The Doctrine\ORM\Mapping\InverseJoinColumns need to be registered to ?

https://github.com/rectorphp/rector-src/blob/444cbd20d755c6c1a942ef4bfdc0860c633adcc9/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php

Could you try to provide a fix as well? Thank you.

[fezfez]

hello @samsonasik, i've done a fix, it's pretty ugly but it work.

[fezfez]

@samsonasik : CI is green + i've rebase

[samsonasik]

One more thing #1142 (comment) . also, new service is no need to be registered, should be auto registered.

[fezfez]

@samsonasik : done

[TomasVotruba]

Thank you 😊

[usu]

I think there's a typo in the attribute name: Should be Doctrine\ORM\Mapping\InverseJoinColumn (without trailing s). Not sure though if this only needs to be fixed here or at other places, too.

https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/attributes-reference.html#attrref_manytomany

[samsonasik]

@fezfez could you verify and update rector-doctrine as well if Doctrine\ORM\Mapping\InverseJoinColumns should be Doctrine\ORM\Mapping\InverseJoinColumn ?

Thank you.