[Downgrade PHP 7.0] Add DowngradeDirnameLevelsRector #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return new FuncCall(new Name(self::DIRNAME), [$pathArg]); | ||
| } | ||
| } |
There was a problem hiding this comment.
We use pre-upgrade code for readability. So even downgraded code can be read by humans.
The syntax for these is dirname(dirname(...)).
Could you update it?
There was a problem hiding this comment.
I've made the change.
There are still cases that I don't handle, like:
$levels = 2;
dirname($path, $levels);Since Rector relies on PHPStan, it's should be possible to do better but I don't know how.
Do you know if there are others rectors doing something like that? I could use them as examples.
samsonasik
reviewed
Nov 10, 2021
rules/DowngradePhp70/Rector/FuncCall/DowngradeDirnameLevelsRector.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
Thank you, I see the is difference between static and dynamic second argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.