[DeadCode][TypeDeclaration] Handle Nullable Param on RemoveUnusedPrivateMethodParameterRector+RemoveUnreachableStatementRector+AddArrayParamDocTypeRector

[samsonasik]

Given the following code:

use PhpParser\Node\Stmt\ClassLike;

class Fixture
{
    public function run(?ClassLike $classLike): bool
    {
        if (! $classLike instanceof ClassLike) {
            return false;
        }

        return $this->callPrivateMethod($classLike, true);
    }

    private function callPrivateMethod(ClassLike $classLike, bool $value)
    {
        return $classLike->getMethods() !== [];
    }
}

It produce addition docblock:

+    /**
+     * @param \ClassLike|null $classLike
+     */

while removing unused parameter in private method. The Param itself is invalid as there is no \ClassLike class, but PhpParser\Node\Stmt\ClassLike which imported in use statement.

Applied rules:

Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
Rector\DeadCode\Rector\Stmt\RemoveUnreachableStatementRector;
Rector\TypeDeclaration\Rector\ClassMethod\AddArrayParamDocTypeRector;

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

This would falsy transform all short object types to mixed. That's incorrect.

Instead we should find out, why the short class name is resolved. It will affect more rules.
IMO it will be related somehow to NameResolver.

[samsonasik]

Fixed with namespacedName attribute in a Name node check 9e49b53 🎉

[samsonasik]

oh, that's seems broke sabbelasichon/typo3-rector package test now https://github.com/rectorphp/rector-src/runs/4189871248?check_suite_focus=true#step:7:24

[TomasVotruba]

This looks better! 👍

It broke the typo3 package probalby, not sure why. Could you check it?

[samsonasik]

I will try.

[samsonasik]

Fixed 🎉 by move the namespacedName check under NullableType for verify its type 9304060

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you