[Downgrade PHP 5.6] Add DowngradeArgumentUnpackingRector

config/set/downgrade-php56.php

@@ -4,6 +4,7 @@
 
 use Rector\Core\Configuration\Option;
 use Rector\Core\ValueObject\PhpVersion;
+use Rector\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector;
 use Rector\DowngradePhp56\Rector\Pow\DowngradeExponentialAssignmentOperatorRector;
 use Rector\DowngradePhp56\Rector\Pow\DowngradeExponentialOperatorRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -13,6 +14,7 @@
     $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_55);
 
     $services = $containerConfigurator->services();
+    $services->set(DowngradeArgumentUnpackingRector::class);
     $services->set(DowngradeExponentialAssignmentOperatorRector::class);
     $services->set(DowngradeExponentialOperatorRector::class);
 };

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/DowngradeArgumentUnpackingRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class DowngradeArgumentUnpackingRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/func_call_inlined_args.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(mixed $item)
+    {
+        some_function('foo', ...[$item, 'baz'], 'bar', 'qux');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(mixed $item)
+    {
+        call_user_func_array('some_function', ['foo', $item, 'baz', 'bar', 'qux']);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/func_call_mixed_args.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items)
+    {
+        some_function('foo', 'bar', ...$items, 'baz');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items)
+    {
+        call_user_func_array('some_function', array_merge(['foo', 'bar'], $items, ['baz']));
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/func_call_multi_unpack_args.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items, array $otherItems)
+    {
+        some_function(...$items, ...$otherItems);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items, array $otherItems)
+    {
+        call_user_func_array('some_function', array_merge($items, $otherItems));
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/func_call_one_arg.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items)
+    {
+        some_function(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $items)
+    {
+        call_user_func_array('some_function', $items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/method_call_chained.php.inc

@@ -0,0 +1,47 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function chain()
+    {
+        return $this;
+    }
+
+    public function call(array $items)
+    {
+        $this->chain(...$items)->run(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function chain()
+    {
+        return $this;
+    }
+
+    public function call(array $items)
+    {
+        call_user_func_array([call_user_func_array([$this, 'chain'], $items), 'run'], $items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/method_call_expr.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function call(array $items)
+    {
+        $method = 'run';
+        $this->$method(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function call(array $items)
+    {
+        $method = 'run';
+        call_user_func_array([$this, $method], $items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/method_call_one_arg.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function call(array $items)
+    {
+        $this->run(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass
+{
+    public function run()
+    {
+        var_dump(func_get_args());
+    }
+
+    public function call(array $items)
+    {
+        call_user_func_array([$this, 'run'], $items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/new_class.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(array $items)
+    {
+        return new SomeClass(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(array $items)
+    {
+        return (new \ReflectionClass(SomeClass::class))->newInstanceArgs($items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/new_expr.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(array $items)
+    {
+        $class = 'SomeClass';
+        return new $class(...$items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(array $items)
+    {
+        $class = 'SomeClass';
+        return (new \ReflectionClass($class))->newInstanceArgs($items);
+    }
+}
+
+?>

rules-tests/DowngradePhp56/Rector/CallLike/DowngradeArgumentUnpackingRector/Fixture/new_inlined_args.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(mixed $item)
+    {
+        return new SomeClass(...['foo', $item]);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp56\Rector\CallLike\DowngradeArgumentUnpackingRector\Fixture;
+
+final class SomeClass extends stdClass
+{
+    public function run(mixed $item)
+    {
+        return new SomeClass('foo', $item);
+    }
+}
+
+?>