Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Avoid error Rector\Core\Rector\AbstractRector::isObjectType() must implement interface PhpParser\Node, null given on AddParamTypeDeclarationRector #1239

Merged
merged 1 commit into from Nov 15, 2021

Conversation

samsonasik
Copy link
Member

Avoid error like:

Error: ] Could not process "system/Cookie/CloneableCookieInterface.php" file,   
         due to:                                                                
         "Argument 1 passed to Rector\Core\Rector\AbstractRector::isObjectType()
         must implement interface PhpParser\Node, null given, called in         
         vendor/rector/rector/rules/TypeDeclaration/Rector/ClassMethod/AddParamT
         ypeDeclarationRector.php:83". On line: 315        

ref codeigniter4/CodeIgniter4#5320 (comment)

Closes #1218 , The non ClassLike already handled in shouldSkip() method.

…jectType() must implement interface PhpParser\Node, null given on AddParamTypeDeclarationRector
@samsonasik samsonasik merged commit 5154b53 into main Nov 15, 2021
@samsonasik samsonasik deleted the avoid-error-is-object-type-null branch November 15, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant