[Rector] add PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD

[kenjis]

Description

• to fix assertion method like AssertCompareToSpecificMethodRector

See https://github.com/rectorphp/rector-phpunit#rector-rules-for-phpunit

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• [] User guide updated
• [] Conforms to style guide

[samsonasik]

@kenjis could you run:

vendor/bin/rector

and commit the change?

[kenjis]

@samsonasik I committed.

I also added PHPUnitSetList::PHPUNIT_80,
PHPUnitSetList::PHPUNIT_90,
PHPUnitSetList::PHPUNIT_91.

[samsonasik]

@kenjis I think we can add setlist one by one, as it cause error :

Error: ] Could not process "system/Cookie/CloneableCookieInterface.php" file,   
         due to:                                                                
         "Argument 1 passed to Rector\Core\Rector\AbstractRector::isObjectType()
         must implement interface PhpParser\Node, null given, called in         
         vendor/rector/rector/rules/TypeDeclaration/Rector/ClassMethod/AddParamT
         ypeDeclarationRector.php:83". On line: 315        

first, ensure PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD working first, and we can add more set in separate PR.

If we have specific rule that failed, eg: AddParamTypeDeclarationRector above, we can skip first under Option::SKIP on specific file.

[kenjis]

@samsonasik Okay, I will do one by one. Thanks!

[kenjis]

This assertion fails. Because $attributes is

array (4) [
    'foo' => null
    'bar' => null
    'default' => string (6) "sumfin"
    'created_at' => null
]

What do we do?

[samsonasik]

You can register Rector\PHPUnit\Rector\MethodCall\AssertIssetToSpecificMethodRector into Option::SKIP

use Rector\PHPUnit\Rector\MethodCall\AssertIssetToSpecificMethodRector;

    $parameters->set(Option::SKIP, [
             // ....

            AssertIssetToSpecificMethodRector::class => [
                     __DIR__ . '/tests/system/Entity/EntityTest.php',
           ],
    ]);

and then rollback change for tests/system/Entity/EntityTest.php

[kenjis]

This assertion fails.

[kenjis]

This assertion fails.

[samsonasik]

You can register Rector\PHPUnit\Rector\MethodCall\AssertIssetToSpecificMethodRector into Option::SKIP

use Rector\PHPUnit\Rector\MethodCall\AssertIssetToSpecificMethodRector;

    $parameters->set(Option::SKIP, [
             // ....

            AssertIssetToSpecificMethodRector::class => [
                     __DIR__ . '/tests/system/Entity/EntityTest.php',
                    __DIR__ . '/tests/system/Session/SessionTest.php',
           ],
    ]);

and then rollback change for tests/system/Entity/EntityTest.php and tests/system/Session/SessionTest.php

[samsonasik]

If AssertIssetToSpecificMethodRector cause invalid result in many places, we can just skip it al together:

use Rector\PHPUnit\Rector\MethodCall\AssertIssetToSpecificMethodRector;

    $parameters->set(Option::SKIP, [
             // ....

            AssertIssetToSpecificMethodRector::class,
    ]);

[kenjis]

I would rather change the test code to remove the skip AssertIssetToSpecificMethodRector.

Thank you for telling me about rector!