[Downgrade PHP 5.5] Add DowngradeArbitraryExpressionArgsToEmptyAndIssetRector

[villfa]

No description provided.

[samsonasik]

how about ArrayDimFetch? could you add example fixture for this:

empty(some_function()['test'])

https://3v4l.org/M44H1

[villfa]

Thank you @samsonasik!
This case is correctly supported now.

[samsonasik]

Thank you @villfa

[samsonasik]

@villfa could you create another use case for PropertyFetch/StaticPropertyFetch ?

class A
{
    
}

$a = new A();
isset($a->test);
$a->test !== null;

https://3v4l.org/DD4hG

If the use cases are mostly on function call, method call, and static call, I think you can use flipped check:

if ($this->callAnalyzer->isObjectCall($expr) ||  $this->callAnalyzer->isNewInstance($expr) || $expr instanceof FuncCall)

wdyt?

[villfa]

I think you're right. I'll prepare a new PR to fix the missing cases.