[DeadCode][EarlyReturn] Handle RemoveUnusedVariableAssignRector + RemoveAlwaysElseRector

[samsonasik]

Given the following code:

final class Fixture
{
    public function run(Request $request)
    {
        $path = $request->get('path', null);
        $url  = $request->get('url', null);

        if (null !== $path) {
            return response()->file($path);
        } elseif (null !== $url) {
            return response()->getFile($url);
        }

        throw new \Exception('Error');
    }
}

It produce:

-        $path = $request->get('path', null);
+        $request->get('path', null);

which should not.

Applied rules:

Rector\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector;
Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;

Fixes rectorphp/rector#6819

[samsonasik]

Fixed 🎉

[samsonasik]

@TomasVotruba it fixed 🎉 , the rector-doctrine package tests error is unrelated.

[samsonasik]

rebased.

[samsonasik]

@TomasVotruba using p5 on paratest seems cause error again after rebase:

https://github.com/rectorphp/rector-src/runs/4273392519?check_suite_focus=true#step:5:64

In WorkerCrashedException.php line 36:
                                                                               
  The command "'/home/runner/work/rector-src/rector-src/vendor/phpunit/phpuni  
  t/phpunit' '--configuration' '/home/runner/work/rector-src/rector-src/phpun  
  it.xml' '--no-logging' '--no-coverage' '--printer' 'ParaTest\Runners\PHPUni  
  t\Worker\NullPhpunitPrinter' '--log-junit' '/tmp/PT_ta1J0d' '/home/runner/w  
  ork/rector-src/rector-src/rules-tests/TypeDeclaration/Rector/Property/Typed  
  PropertyFromStrictGetterMethodReturnTypeRector/TypedPropertyFromStrictGette  
  rMethodReturnTypeRectorTest.php'" failed.                                    
                                                                               
  Exit Code: 137(Kill (terminate immediately))   

[samsonasik]

@TomasVotruba using p3 on parallel tests seems solve it 🎉

All checks have passed 🎉 it is ready for review.

[samsonasik]

I am merging it ;)

[cavo789]

Just incredible 👌