[PHP 8.1] Add nested attributes arguments + keep short ORM\* aliases #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-nested-attributes-2
branch
from
d979a42
to
b08fc59
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-nested-attributes-2
branch
from
6288688
to
a60624f
Compare
TomasVotruba
force-pushed
the
tv-nested-attributes-2
branch
from
a60624f
to
480e260
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-nested-attributes-2
branch
from
bfa5afa
to
cb84955
Compare
This was referenced Nov 20, 2021
TomasVotruba
changed the title
TomasVotruba
commented
Nov 20, 2021
| - run: vendor/bin/paratest -p4 --runner=WrapperRunner ${{ matrix.path }} --colors | ||
| - run: vendor/bin/paratest -p5 --runner=WrapperRunner ${{ matrix.path }} --colors |
There was a problem hiding this comment.
@samsonasik Just FYI, I don't use paratest at all, so I might be missing something.
This job was constantly failing on this PR, for error 137. AFAIK run out of memory.
I tried to change -p to 5 and it seems working 👍 Let me know if there is a better way to handle it.
There was a problem hiding this comment.
@TomasVotruba thank you, it was slower with 5, but seems faster now 👍
TomasVotruba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1266
See rectorphp/rector#6792
Keep short ORM* like aliases
Closes rectorphp/rector#6659, closes rectorphp/rector#6565