[Downgrade PHP 7.0] Add DowngradeClosureCallRector #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules/DowngradePhp70/Rector/MethodCall/DowngradeClosureCallRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Nov 25, 2021
| private function isMethodName(MethodCall $methodCall, string $expectedName): bool | ||
| { | ||
| if ($methodCall->name instanceof Identifier) { | ||
| $comparison = strcasecmp($methodCall->name->toString(), $expectedName); |
There was a problem hiding this comment.
this may be needed to be moved to separate private method to be reusable so can change in one place when there is logic change for comparison.
|
@villfa Thank you for you work 👍 It's amazing how you cover every downgrade step one by one 🙇 @samsonasik Feel free to merge as you feel this is ready 👍 |
samsonasik
approved these changes
Nov 25, 2021
|
Thank you @villfa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.