[DeadCode] Add support remove unused in between private method parameter for RemoveUnusedPrivateMethodParameterRector #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove param+arg in caller in RemoveUnusedPrivateMethodParameterRector
samsonasik
force-pushed
the
remove-unused-in-between-private-method-param-args
branch
from
4a34ce9
to
3cfe09e
Compare
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
changed the title
TomasVotruba
approved these changes
Nov 27, 2021
|
Thank you 😊 very nice improvement |
samsonasik
deleted the
remove-unused-in-between-private-method-param-args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove both of:
Fixes rectorphp/rector#6834