[DowngradePhp81] Add DowngradeArraySpreadStringKeyRector #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
add-downgrade-array-spread-string-key
branch
from
fc81fc1
to
e2cec40
Compare
samsonasik
force-pushed
the
add-downgrade-array-spread-string-key
branch
from
ee6eef1
to
b60597e
Compare
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you |
samsonasik
commented
Dec 3, 2021
| $parts = ['a' => 'b']; | ||
| $parts2 = ['c' => 'd']; | ||
|
|
||
| $result = [...$parts, ...$parts2]; |
There was a problem hiding this comment.
Oops, before and after is same, it should not, I will create new PR to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is php 7.4's
DowngradeArraySpreadRector, but downgrading array spread will only applied if user downgrade into php 7.4.This PR add
DowngradeArraySpreadStringKeyRectorif user want to downgrade from php 8.1 into php 8.0 only, which php 8.0 doesn't support string key array spread yet, so it changed to array_merge.The
DowngradeArraySpreadStringKeyRectorextends existingDowngradeArraySpreadRectorwhich apply when key is string.