Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] [DeadCode] Refactor RectifiedAnalyzer and ExprUsedInNextNodeAnalyzer #1533

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 20, 2021

  • Update RectifiedAnalyzer to use specific Nodes ( Assign and Class_ ) for allowed apply :
   Rector Rule <-> Same Node <-> Same File
  • Clean up ExprUsedInNextNodeAnalyzer as $isCheckNameScope 2nd parameter no longer needed.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit c51fcbf into main Dec 20, 2021
@TomasVotruba TomasVotruba deleted the refactor-rectified branch December 20, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants