[TypeDeclaration] AddVoidReturnTypeWhereNoReturnRector turns @return never into less specific @return void
#1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
@return never into less specific @return void
staabm
commented
Dec 23, 2021
Comment on lines
+16
to
+41
| /** | ||
| * @return never-return | ||
| */ | ||
| public function neverReturn() | ||
| { | ||
| header('Location: example.com'); | ||
| exit(); | ||
| } | ||
|
|
||
| /** | ||
| * @return never-returns | ||
| */ | ||
| public function neverReturns() | ||
| { | ||
| header('Location: example.com'); | ||
| exit(); | ||
| } | ||
|
|
||
| /** | ||
| * @return no-return | ||
| */ | ||
| public function noReturn() | ||
| { | ||
| header('Location: example.com'); | ||
| exit(); | ||
| } |
There was a problem hiding this comment.
it seems rector does not support all "aliases" of the bottom-type phpstan supports:
https://phpstan.org/writing-php-code/phpdoc-types#bottom-type
only @return never is turned into the NeverType ..
There was a problem hiding this comment.
fixed in the latest commit
staabm
changed the title
@return never into less specific @return void@return never into less specific @return void
staabm
changed the title
@return never into less specific @return void@return never into less specific @return void
staabm
commented
Dec 23, 2021
| @@ -36,7 +36,7 @@ final class ScalarStringToTypeMapper | |||
| ResourceType::class => ['resource'], | |||
| CallableType::class => ['callback', 'callable'], | |||
| ObjectWithoutClassType::class => ['object'], | |||
| NeverType::class => ['never'], | |||
| NeverType::class => ['never', 'never-return', 'never-returns', 'no-return'], | |||
There was a problem hiding this comment.
added all phpstan bottom types: see https://phpstan.org/writing-php-code/phpdoc-types#bottom-type
samsonasik
approved these changes
Dec 23, 2021
|
Thank you @staabm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#6892