Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddVoidReturnTypeWhereNoReturnRector does not update trait methods #1555

Closed
wants to merge 1 commit into from
Closed

AddVoidReturnTypeWhereNoReturnRector does not update trait methods #1555

wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 23, 2021

@staabm staabm changed the title Added failling test AddVoidReturnTypeWhereNoReturnRector does not update trait methods Dec 23, 2021
@staabm
Copy link
Contributor Author

staabm commented Dec 23, 2021

I don't know what the hasExclusiveVoid check is about, but this test is failling because rector is running into this condition

rector-src/rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php

Lines 98 to 100 in e546dbb

if (! $this->silentVoidResolver->hasExclusiveVoid($node)) {
return null;
}

@TomasVotruba
Copy link
Member

Thank you 👍

Cherry picked in #1582

@staabm staabm deleted the void-trait branch December 27, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @TomasVotruba @clxmstaab