Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php74] Skip protected property on final class with parent not loaded on TypedPropertyRector #1560

Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 24, 2021

Parent Class can be not loaded due to autoload overlapped. Given the following code:

final class SkipProtectedPropertyWithParentNotLoaded extends NotLoadedClass
{
    /**
     * @var string
     */
    protected $type;
}

It currently produce:

-    /**
-     * @var string
-     */
-    protected $type;
+    protected string $type;

which should be skipped.

@samsonasik samsonasik changed the title [Php74] Skip property property on final class with parent not loaded on TypedPropertyRector [Php74] Skip protected property on final class with parent not loaded on TypedPropertyRector Dec 24, 2021
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik force-pushed the skip-protected-property-final-with-parent-not-loaded branch from c2d481a to f31a673 Compare December 24, 2021 16:03
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit b7da222 into main Dec 24, 2021
@TomasVotruba TomasVotruba deleted the skip-protected-property-final-with-parent-not-loaded branch December 24, 2021 20:38
@TomasVotruba
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants