Faking scope context for trait reflections #1575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PHPStan does not traverse trait without a class, Rector used class
Rector\Core\Stubs\DummyTraitClass
for faking class reflection for trait reflections. But this solution makes it impossible to get param php doc from the faked scope, which makes the param tags no longer useful in traits.For example, in this example, because the param tag
@param string|null $column
can't get in the faked scope, the type of$column
resolved fromNodeTypeResolver
will bemixed
notstring|null
This PR changing the scope context in a crude way, just for reference.