-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parallel] Improve tests to use file processor over file analyzer + fix missing RectorWithLineChange de/serialization #1584
Conversation
390b787
to
a047761
Compare
a047761
to
dec98e9
Compare
dec98e9
to
4087522
Compare
0838612
to
bd176e5
Compare
@TomasVotruba the git checkout main
git commit --allow-empty -m "Trigger notification"
git push origin main |
@TomasVotruba the scoped build seems still error on latest build on parallel lint, ref https://github.com/rectorphp/rector-src/runs/4649685575?check_suite_focus=true#step:14:79 Parse error: rector-prefixed-downgraded/vendor/rector/rector-nette/src/FileProcessor/NeonFileProcessor.php:44
42| {
43| if ($this->neonRectors === []) {
> 44| return;
45| }
46| $fileContent = $file->getFileContent();
A function with return type must return a value in rector-prefixed-downgraded/vendor/rector/rector-nette/src/FileProcessor/NeonFileProcessor.php on line 44 |
@TomasVotruba I created PR efabrica-team/rector-nette#53 for it. |
@TomasVotruba it works 🎉 |
Thank you 👍 |
Ref rectorphp/rector#2971