Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parallel] Improve tests to use file processor over file analyzer + fix missing RectorWithLineChange de/serialization #1584

Merged
merged 6 commits into from
Dec 28, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Dec 28, 2021

@TomasVotruba TomasVotruba changed the title fix extra line number [Parallel] Improve tests to use file processor over file analyzer Dec 28, 2021
@TomasVotruba TomasVotruba changed the title [Parallel] Improve tests to use file processor over file analyzer [Parallel] Improve tests to use file processor over file analyzer + fix missing RectorWithLineChange de/serialization Dec 28, 2021
@TomasVotruba TomasVotruba enabled auto-merge (squash) December 28, 2021 10:34
@TomasVotruba TomasVotruba merged commit 0344f30 into main Dec 28, 2021
@TomasVotruba TomasVotruba deleted the tv-parallel-5 branch December 28, 2021 10:37
@samsonasik
Copy link
Member

samsonasik commented Dec 28, 2021

@TomasVotruba the note [skip ci] message seems make scoped build not started, could you create an empty commit to push to main branch to trigger build?

git checkout main
git commit --allow-empty -m "Trigger notification"
git push origin main

@samsonasik
Copy link
Member

@TomasVotruba the scoped build seems still error on latest build on parallel lint, ref https://github.com/rectorphp/rector-src/runs/4649685575?check_suite_focus=true#step:14:79

Parse error: rector-prefixed-downgraded/vendor/rector/rector-nette/src/FileProcessor/NeonFileProcessor.php:44
    42|     {
    43|         if ($this->neonRectors === []) {
  > 44|             return;
    45|         }
    46|         $fileContent = $file->getFileContent();
A function with return type must return a value in rector-prefixed-downgraded/vendor/rector/rector-nette/src/FileProcessor/NeonFileProcessor.php on line 44

@samsonasik
Copy link
Member

@TomasVotruba I created PR efabrica-team/rector-nette#53 for it.

@samsonasik
Copy link
Member

@TomasVotruba it works 🎉

Screen Shot 2021-12-28 at 19 09 01

@TomasVotruba
Copy link
Member Author

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants