Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DowngradePhp80] Add DowngradeArrayFilterNullableCallbackRector #1593

Merged
merged 21 commits into from
Dec 30, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik force-pushed the add-downgrade-array-filter-nullable branch 2 times, most recently from c4b25ff to f34b712 Compare December 30, 2021 11:43
@samsonasik samsonasik marked this pull request as draft December 30, 2021 12:13
@samsonasik samsonasik marked this pull request as ready for review December 30, 2021 14:18
@samsonasik
Copy link
Member Author

implemented 🎉

@TomasVotruba TomasVotruba enabled auto-merge (squash) December 30, 2021 14:22
@TomasVotruba TomasVotruba merged commit 51ad4b8 into main Dec 30, 2021
@TomasVotruba TomasVotruba deleted the add-downgrade-array-filter-nullable branch December 30, 2021 14:22
@samsonasik
Copy link
Member Author

Downgrade build seems error now, ref https://github.com/rectorphp/rector-src/runs/4667411662?check_suite_focus=true#step:9:37505

PHP Fatal error:  Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given, called in phar:///home/runner/work/rector-src/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php on line 1039 and defined in phar:///home/runner/work/rector-src/rector-src/vendor/phpstan/phpstan/phpstan.phar/src/Type/Constant/ConstantIntegerType.php:27

I will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants