[Core] Fix undefined array key 0 on FormatPerservingPrinter

[samsonasik]

Fixes rectorphp/rector#6907 Closes #1618

[samsonasik]

Checking current stmts seems remove use statement:

1) Rector\Core\Tests\Issues\PrintStmtsIndex\PrintStmtsIndexTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
tests/Issues/PrintStmtsIndex/Fixture/fixture.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 <?php
 
-use Illuminate\Http\Request;
-

which should not.

[samsonasik]

Fixed 🎉

[samsonasik]

@gander I updated the fixture to show the changed Request to \Illuminate\Http\Request 0b9a682

[samsonasik]

The configured config :

   $services->set(RenameClassRector::class)
        ->configure([
            'Request' => 'Illuminate\Http\Request',
        ]);

applied succesfully, but it still removes the use statement, which should not.

[samsonasik]

@gander I updated fixture config to show it change Route to \Illuminate\Support\Facades\Route as well 29905df

[gander]

The code originally had unused use:

use Illuminate\Http\Request;

and it was removed during the process, so there was no element with index 0. I don't know if adding a use of this class will break the initialization code for this error?

[samsonasik]

I added fixtures for auto import enabled d6b6266 seems will make issue :

1) Rector\Core\Tests\Issues\PrintStmtsIndexAutoImport\PrintStmtsIndexAutoImportTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
tests/Issues/PrintStmtsIndexAutoImport/Fixture/fixture_request_call.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 <?php
 
 use Illuminate\Support\Facades\Route;
-use Illuminate\Http\Request;

[samsonasik]

rolling back FormatPerservingPrinter, it possibly the change should be in RenameClassRector

[samsonasik]

Fixed 🎉 with ensure use name has \ for short name use compare check 6fd270e

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Thank you, let's ship it