[parallel] Let WorkerRunner know about paths, so PHPStan and Rector can handle static reflection over them #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-parallel-class-not-found-2
branch
from
6c766b8
to
b831848
Compare
TomasVotruba
commented
Jan 4, 2022
TomasVotruba
commented
Jan 4, 2022
Comment on lines
-36
to
+51
| if ($matchedExpectedOutput === false) { | ||
| echo "\nEXPECTED:\n"; | ||
| var_dump($expectedOutput); | ||
| echo "\nACTUAL:\n"; | ||
| var_dump($output); | ||
| exit(1); | ||
| } | ||
| // print color diff, to make easy find the differences | ||
| $consoleDiffer = new ConsoleDiffer(new Differ(), new ColorConsoleDiffFormatter()); | ||
| $diff = $consoleDiffer->diff($output, $expectedOutput); | ||
| $symfonyStyle->writeln($diff); |
There was a problem hiding this comment.
The former report only showed full texts and reported "some difference somewhere".
Now the diff only shows which exact line is different 👍 e.g.
TomasVotruba
commented
Jan 4, 2022
| ) { | ||
| } | ||
|
|
||
| public function run(Encoder $encoder, Decoder $decoder, Configuration $configuration): void | ||
| { | ||
| $this->dynamicSourceLocatorDecorator->addPaths($configuration->getPaths()); |
There was a problem hiding this comment.
The 1st missing part was paths here. That's how we can tell Rector and PHPStan to use static reflection on specific directories
TomasVotruba
commented
Jan 4, 2022
Comment on lines
75
to
+78
|
|
||
| // 1. allow PHPStan to work with static reflection on provided files | ||
| $this->nodeScopeResolver->setAnalysedFiles($filePaths); | ||
|
|
There was a problem hiding this comment.
The 2nd missing part was here. Now scope analyzer can work with provided paths.
samsonasik
reviewed
Jan 4, 2022
TomasVotruba
force-pushed
the
tv-parallel-class-not-found-2
branch
from
b831848
to
678232e
Compare
TomasVotruba
force-pushed
the
tv-parallel-class-not-found-2
branch
from
678232e
to
5233f22
Compare
|
@samsonasik Ready for review and merge 👍 |
|
@TomasVotruba let's give it a try and let's see if we can add more directory to list of downgrade parallel. |
samsonasik
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1613 (closes #1613)
Fixes rectorphp/rector#6903