Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Prevent existing type override by mixed #1642

Merged
merged 2 commits into from
Jan 7, 2022
Merged

[TypeDeclaration] Prevent existing type override by mixed #1642

merged 2 commits into from
Jan 7, 2022

Conversation

zingimmick
Copy link
Contributor

Existing type override by mixed type in php doc.

     /**
-     * @var array<string, bool>
+     * @var mixed
      */
     private $rules = [];

@zingimmick zingimmick changed the title Add failing test fixture for TypedPropertyFromStrictGetterMethodReturnTypeRector [TypeDeclaration] Prevent existing type override by mixed Jan 7, 2022
@zingimmick zingimmick marked this pull request as draft January 7, 2022 04:45
@zingimmick zingimmick marked this pull request as ready for review January 7, 2022 05:38
@samsonasik samsonasik merged commit 111bf5d into rectorphp:main Jan 7, 2022
@samsonasik
Copy link
Member

Thank you @zingimmick

@zingimmick zingimmick deleted the patch-1 branch January 7, 2022 06:36
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zingimmick @samsonasik @TomasVotruba