[DowngradePhp80] Add DowngradeNumberFormatNoFourthArgRector

[samsonasik]

In php 8.0, number_format allow up to 3rd argument without 4th argument, eg:

echo number_format(1000, 2, ',');

but it will cause error in php 7.x, ref https://3v4l.org/pq9e1

This PR add DowngradeNumberFormatNoFourthArgRector to add 4th argument by default value.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Thank you 👍

[TomasVotruba]

Mm, it seems after switching to "merge" strategy, all the detailed commits are now part of main branch:
https://github.com/rectorphp/rector-src/commits/main

Do you think you could squash to 1-3 important commits next time? So we have only meaninful history of commits

[staabm]

This "fix" looks like a workaround

[samsonasik]

Yes

[samsonasik]

that's possibly due to cs fixer:

-     * @param Node|Node[] $nodes
-     * @param callable(Node $node): bool $filter
+     * @param Node|Node[] $filters
+     * @param callable(Node $filter): bool $filter
      */
     public function findFirst(Node | array $nodes, callable $filter): ?Node
     {
    ----------- end diff -----------


Applied checkers:

 * PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer
 * PhpCsFixer\Fixer\Operator\UnaryOperatorSpacesFixer
 * PhpCsFixer\Fixer\Semicolon\NoSinglelineWhitespaceBeforeSemicolonsFixer
 * Symplify\CodingStandard\Fixer\Commenting\ParamReturnAndVarTagMalformsFixer

[samsonasik]

Ok, it seems because of Symplify\CodingStandard\Fixer\Commenting\ParamReturnAndVarTagMalformsFixer

[samsonasik]

@TomasVotruba will try 👍