[DowngradePhp80] Use ArgsAnalyzer for has named args check #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
use-args-analyzer-named-check
branch
from
670684b
to
948a0fc
Compare
samsonasik
force-pushed
the
use-args-analyzer-named-check
branch
from
681119d
to
fccb147
Compare
|
@TomasVotruba I think we should back to "Squash and merge" as use "Merge commit" will took back and forth to rebase and restructure meaningfull commit as we have many CI that need to be verified. |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
@samsonasik Allright, I thought we have some workflows agains that change. I've updated it back so we don't burry ourselves in extra work. Thanks 👍 |
|
The generated changelogs for new Rector release were also full of detailed commits after switch to "merge". It took much longer to go through with same repeated commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.