Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parallel] Increase ParallelFileProcessor::TIMEOUT_IN_SECONDS to 120 #1657

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 11, 2022

Tested in macbook pro 2011 dual core i5, running parallel on CodeIgniter4 project, with 60 seconds timeout, it got error:

vendor/bin/rector 
 120/688 [▓▓▓▓░░░░░░░░░░░░░░░░░░░░░░░░]  17%
                                                                                                                        
 [ERROR] Could not process                                                                                              
         "/Users/samsonasik/www/CodeIgniter4/vendor/rector/rector/vendor/symplify/easy-parallel/src/ValueObject/Parallel
         Process.php" file, due to:                                                                                     
         "Child process timed out after 60 seconds". On line: 100                                                       
                                                                                                                        

                                                                                                                        
 [ERROR] Could not process some files, due to:                                                                          
         "Reached system errors count limit of 20, exiting...".                                                                                                                               

with 120 seconds, it got working ok:

vendor/bin/rector --clear-cache
 688/688 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                   
                                                                                                                                                                                                                        
                                                                                                                                                                                                                     
                                                                                                                        

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit fb76afb into main Jan 11, 2022
@TomasVotruba TomasVotruba deleted the increase-timeout-in-seconds branch January 11, 2022 15:20
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants