[Php70] Handle reverse sorting check on IfToSpaceshipRector #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Jan 14, 2022
Comment on lines
-33
to
-39
| usort($languages, function ($a, $b) { | ||
| if ($a[0] === $b[0]) { | ||
| return 0; | ||
| } | ||
|
|
||
| return ($a[0] < $b[0]) ? -1 : 1; | ||
| }); |
There was a problem hiding this comment.
I removed above skip as it seems applied now:
- if ($a[0] === $b[0]) {
- return 0;
- }
-
- return ($a[0] < $b[0]) ? -1 : 1;
+ return $a[0] <=> $b[0];
});moved to new fixture d0e7b44
ref https://3v4l.org/6jaK6 and https://3v4l.org/ReF9k for check equal result.
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
I am merging it ;) |
|
Thank you 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1674
Fixes rectorphp/rector#6938