[Php74] Mirror comment on Closure return to ArrowFunction expr on ClosureToArrowFunctionRector #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Failing Test for ClosureToArrowFunctionRector Based on https://getrector.org/demo/1ec6e7f1-7c0f-684e-9843-a7cd56252edf
samsonasik
force-pushed
the
close-1641-take-2
branch
from
40705ea
to
9897a9b
Compare
samsonasik
commented
Jan 14, 2022
| */ | ||
| // something | ||
| // @psalm-suppress UndefinedFunction | ||
| ff(); |
There was a problem hiding this comment.
this tweak on BetterStandardPrinter::p() currently make duplicate comment for existing arrow function:
*/
// something
// @psalm-suppress UndefinedFunction
- ff();
+ /**
+ * comment
+ */
+// something
+// @psalm-suppress UndefinedFunctionwhich incorrect.
There was a problem hiding this comment.
resolved by add new AttributeKey to flag if comment is mirrored 6f29de7
samsonasik
force-pushed
the
close-1641-take-2
branch
from
eea7956
to
b75c112
Compare
samsonasik
commented
Jan 14, 2022
| ----- | ||
| <?php | ||
|
|
||
| fn() => /** @psalm-suppress UndefinedFunction */ |
There was a problem hiding this comment.
keep start comment on current line is on purpose to avoid make creating a tab spaces which will fail on compare in test.
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1641
Fixes rectorphp/rector#6916